feat: Add luxon configuration with locale weeks set to true#759
Open
ShtibsDev wants to merge 2 commits intoreact-component:masterfrom
Open
feat: Add luxon configuration with locale weeks set to true#759ShtibsDev wants to merge 2 commits intoreact-component:masterfrom
true#759ShtibsDev wants to merge 2 commits intoreact-component:masterfrom
Conversation
Add configuration option for luxon with `useLocaleWeeks` for better flexebility.\nThe new configuration is exported seperetly in order to make an additional option and not cause breaking changes.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #759 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 63 63
Lines 2531 2533 +2
Branches 667 667
=======================================
+ Hits 2495 2497 +2
Misses 33 33
Partials 3 3 ☔ View full report in Codecov by Sentry. |
Author
|
Hello, are there any issues with merging it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add configuration option for luxon with
useLocaleWeeksfor better flexebility.The new configuration is exported seperetly in order to make an additional option and not cause breaking changes.